v3.3.6882 - offers to delete wrong frame

A place to report problems and bugs in SharpCap
Forum rules


If you have a problem or question, please check the FAQ to see if it already has an answer : https://www.sharpcap.co.uk/sharpcap-faqs

Please also read about Troubleshooting USB Issues before posting.

*** Please do not post license keys - please report any problems with licensing to 'admin' by private message ***

Please include the following details in any bug report:

* Version of SharpCap
* Camera and other hardware being user
* Operating system version
* Contents of the SharpCap log after the problem has occurred.
[If SharpCap crashes, please send the bug report when prompted instead of including the log]
Post Reply
celkins
Posts: 52
Joined: Fri Apr 20, 2018 10:58 pm

v3.3.6882 - offers to delete wrong frame

Post by celkins »

Robin,
capturing IC417; bumped 'scope, so opened Capture->Delete last capture : it offers to delete the wrong file!

SC3.3.6882-delete wronnnnnnnnnng file.png
SC3.3.6882-delete wronnnnnnnnnng file.png (36.95 KiB) Viewed 539 times

Code: Select all

Info   	20:58:27.758905	#1 	Starting...																												in void SharpCap.Program.Main()
Info   	20:58:28.016900	#1 	Setting up bug reporting.																								in void SharpCap.Program.SetupNBUG()
Info   	20:58:28.083899	#1 	Starting thread to log system info																						

[snip]


Copyright © 2019 Chris Rowland
ASCOM Telescope driver for Celestron
Scope Type StarSense CGE Pro 1.20, ASCOM Celestron Telescope Driver., 6.1			in void SharpCap.MountProxy.ASCOM.MountWrapper.TryConnect()
Info   	01:31:43.090991	#1 	The mount reports an alignment mode of algGermanPolar																	in void SharpCap.MountProxy.ASCOM.MountWrapper.TryConnect()
Info   	01:31:43.092491	#1 	Mount 'Celestron Telescope Driver' now Conneted:True																	in void SharpCap.Models.Mount.set_Connected(bool value)
Info   	01:32:32.902752	#1 	Target name changed to I																								in void SharpCap.Models.Application.set_TargetName(string value)
Info   	01:32:33.408742	#1 	Target name changed to IC																								in void SharpCap.Models.Application.set_TargetName(string value)
Info   	01:32:34.343232	#1 	Target name changed to IC4																								in void SharpCap.Models.Application.set_TargetName(string value)
Info   	01:32:34.629730	#1 	Target name changed to IC41																								in void SharpCap.Models.Application.set_TargetName(string value)
Info   	01:32:36.070705	#1 	Target name changed to IC417																							in void SharpCap.Models.Application.set_TargetName(string value)
Info   	01:40:04.286558	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.StartCaptureAction executing											in async Task SharpCap.ViewModels.UIAction.Execute()
Info   	01:40:04.292557	#1 	Started async Task SharpCap.ViewModels.Actions.StartCaptureAction.ExecuteImpl()											in async Task SharpCap.ViewModels.Actions.StartCaptureAction.ExecuteImpl()
Info   	01:40:04.300557	#1 	Started bool SharpCap.Models.Camera.PrepareToCapture()																	in bool SharpCap.Models.Camera.PrepareToCapture()
Info   	01:40:04.313558	#1 	Creating file name provider for target 'IC417', ZWO ASI183MC Pro, Neb-1, Light											in IFileNameProvider SharpCap.Models.Application.CreateFileNameProvider(string targetName)
Info   	01:40:04.317556	#1 	Started bool SharpCap.Models.Camera.PrepareToCapture(IFileNameProvider fileNameProvider)								in bool SharpCap.Models.Camera.PrepareToCapture(IFileNameProvider fileNameProvider)
Debug  	01:40:04.321557	#1 	Prepare to capture on MultiCaptureProvider
   at bool SharpCap.MultiCaptureProvider.PrepareToCapture(IFileNameProvider fnp)
   at bool SharpCap.Models.Camera.PrepareToCapture(IFileNameProvider fileNameProvider)
   at async Task SharpCap.ViewModels.Actions.StartCaptureAction.ExecuteImpl()
   at void System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start<TStateMachine>(ref TStateMachine stateMachine)
   at Task SharpCap.ViewModels.Actions.StartCaptureAction.ExecuteImpl()
   at async Task SharpCap.ViewModels.UIAction.Execute()
   at void System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start<TStateMachine>(ref TStateMachine stateMachine)
   at Task SharpCap.ViewModels.UIAction.Execute()
   at async Task SharpCap.ViewModels.ActionMenuItemViewModel.ExecuteImpl()
   at void System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start<TStateMachine>(ref TStateMachine stateMachine)
   at Task SharpCap.ViewModels.ActionMenuItemViewModel.ExecuteImpl()
   at async void SharpCap.ViewModels.MenuItemViewModel.Execute(object parameter)
   at void System.Runtime.CompilerServices.AsyncVoidMethodBuilder.Start<TStateMachine>(ref TStateMachine stateMachine)
   at void SharpCap.ViewModels.MenuItemViewModel.Execute(object parameter)
   at void SharpCap.ViewModels.ToolbarButtonViewModel.Execute(object parameter)				in bool SharpCap.MultiCaptureProvider.PrepareToCapture(IFileNameProvider fnp)
Info   	01:40:04.327557	#1 	Started bool SharpCap.Base.CaptureProviderBase<T>.PrepareToCapture(IFileNameProvider fnp)								in bool SharpCap.Base.CaptureProviderBase<T>.PrepareToCapture(IFileNameProvider fnp)
Info   	01:40:04.332057	#1 	Ended bool SharpCap.Base.CaptureProviderBase<T>.PrepareToCapture(IFileNameProvider fnp)									in bool SharpCap.Base.CaptureProviderBase<T>.PrepareToCapture(IFileNameProvider fnp)
Info   	01:40:04.336058	#1 	Ended (Success) bool SharpCap.Models.Camera.PrepareToCapture(IFileNameProvider fileNameProvider)						in bool SharpCap.Models.Camera.PrepareToCapture(IFileNameProvider fileNameProvider)
Info   	01:40:04.341557	#1 	Started async Task SharpCap.ViewModels.Actions.StartCaptureAction.ShowCaptureLengthDialog()								in async Task SharpCap.ViewModels.Actions.StartCaptureAction.ShowCaptureLengthDialog()
Debug  	01:40:07.634508	#1 	Started void SharpCap.UI.WPFStartCaptureWindow.OnFormClosed(FormClosedEventArgs e)										in void SharpCap.UI.WPFStartCaptureWindow.OnFormClosed(FormClosedEventArgs e)
Info   	01:40:07.672506	#1 	About to run the capture : LimitType = TimeLimited, LimitCount = 23, LimitTime = 01:00:00 SequenceCount = 1, SequenceInterval = 300					in async Task SharpCap.ViewModels.Actions.StartCaptureAction.ShowCaptureLengthDialog()
Debug  	01:40:07.676007	#1 	Run capture on MultiCaptureProvider
   at bool SharpCap.MultiCaptureProvider.RunCapture(int? frameCountLimit)
   at void SharpCap.Models.Camera.RunCaptureImpl()
   at void SharpCap.Models.Camera.RunCapture()
   at async Task SharpCap.ViewModels.Actions.StartCaptureAction.ShowCaptureLengthDialog()
   at void System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run()
   at void System.Threading.Tasks.AwaitTaskContinuation.RunCallback(ContextCallback callback, object state, ref Task currentTask)
   at void System.Threading.Tasks.Task.FinishContinuations()
   at bool System.Threading.Tasks.Task<TResult>.TrySetResult(TResult result)
   at void System.Runtime.CompilerServices.AsyncTaskMethodBuilder<TResult>.SetResult(TResult result)
   at async Task<TEventArgs> SharpCap.Sequencer.Extensions.EventAsync<TEventArgs>(object objectWithEvent, string eventName, Func<TEventArgs, bool> eventFilter, CancellationToken ct)
   at void System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run()
   at object RuntimeMethodHandle.InvokeMethod(object target, object[] arguments, Signature sig, bool constructor)
   at object System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(object obj, object[] parameters, object[] arguments)
   at object Delegate.DynamicInvokeImpl(object[] args)				in bool SharpCap.MultiCaptureProvider.RunCapture(int? frameCountLimit)
Info   	01:40:07.681007	#1 	Started bool SharpCap.Base.CaptureProviderBase<T>.RunCapture(int? frameCountLimit)										in bool SharpCap.Base.CaptureProviderBase<T>.RunCapture(int? frameCountLimit)
Info   	01:40:07.683008	#1 	Initializing FitsFileWriter at 5496x3672x1x16bits, Bayer_RGGB, 2 bytes per PEL for ZWO ASI183MC Pro						in void SharpCap.Base.FileWriters.FileWriterBase.Initialize(IFileNameProvider fnp, ColourSpaceId colourSpaceId, int width, int height, int bytesPerPixelElement, int significantBitDepth, int colourPlanes, string DeviceName)
Debug  	01:40:07.685506	#1 	Started void SharpCap.Base.BaseImageProvider.OnStartCapture(IColourSpace colourSpaceControl, Size sz, int? frameCountLimit)					in void SharpCap.Base.BaseImageProvider.OnStartCapture(IColourSpace colourSpaceControl, Size sz, int? frameCountLimit)
Info   	01:40:07.686506	#15	=='Capture Write Thread' (New Thread)
Debug  	01:40:07.686506	#15	Started void SharpCap.Base.BaseImageProvider.RunWriteThread()															in void SharpCap.Base.BaseImageProvider.RunWriteThread()
Debug  	01:40:07.688506	#1 	Ended void SharpCap.Base.BaseImageProvider.OnStartCapture(IColourSpace colourSpaceControl, Size sz, int? frameCountLimit)					in void SharpCap.Base.BaseImageProvider.OnStartCapture(IColourSpace colourSpaceControl, Size sz, int? frameCountLimit)
Info   	01:40:07.690007	#1 	Capture Event : StartCapture																							in void SharpCap.MultiCaptureProvider.SendCaptureEvent(object sender, CaptureEventArgs e)
Info   	01:40:07.692007	#1 	StartCapture event received in UI thread																				in async void SharpCap.ViewModels.SharpCapViewModel.appModel_OnCaptureEvent(object sender, CaptureEventArgs e)
Info   	01:40:07.791005	#1 	Ended bool SharpCap.Base.CaptureProviderBase<T>.RunCapture(int? frameCountLimit)										in bool SharpCap.Base.CaptureProviderBase<T>.RunCapture(int? frameCountLimit)
Info   	01:40:07.800009	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.StartCaptureAction complete												in async Task SharpCap.ViewModels.UIAction.Execute()
Debug  	01:40:09.834975	#15	Creating directory D:\carl\SkyShots\IC417\ZWO ASI183MC Pro_Light for capture files										in string SharpCap.Base.FileWriters.TemplatedFilenameProvider.GetFilenameImpl(FrameInfo frameInfo, bool createDir)
Info   	01:40:09.835476	#15	Writing capture settings file to D:\carl\SkyShots\IC417\ZWO ASI183MC Pro_Light\IC417_Neb-1_2020-09-20T00_40_09Z_G117_120s_00001.CameraSettings.txt				in void SharpCap.Models.Camera.WriteCaptureSettingsTextAndHistogram(bool writeHistogram, string filename, string contents)
Info   	01:42:26.081452	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.DeleteLastCaptureAction executing										in async Task SharpCap.ViewModels.UIAction.Execute()
Info   	01:42:44.511179	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.DeleteLastCaptureAction complete										in async Task SharpCap.ViewModels.UIAction.Execute()
Info   	01:42:55.504017	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.DeleteLastCaptureAction executing										in async Task SharpCap.ViewModels.UIAction.Execute()
Info   	01:43:02.138915	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.DeleteLastCaptureAction complete										in async Task SharpCap.ViewModels.UIAction.Execute()
Info   	01:43:59.880562	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.ShowLogAction executing													in async Task SharpCap.ViewModels.UIAction.Execute()
Info   	01:43:59.944562	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.ShowLogAction complete													in async Task SharpCap.ViewModels.UIAction.Execute()
Info   	01:44:26.966665	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.DeleteLastCaptureAction executing										in async Task SharpCap.ViewModels.UIAction.Execute()
Info   	01:45:54.433371	#1 	Toobar/Menu input : SharpCap.ViewModels.Actions.DeleteLastCaptureAction complete										in async Task SharpCap.ViewModels.UIAction.Execute()
celkins
Posts: 52
Joined: Fri Apr 20, 2018 10:58 pm

Re: v3.3.6882 - offers to delete wrong frame

Post by celkins »

Robin,
a further instance of the same fault from the other instance of SC that I have running
SCv3.3.6882-wrong-file2.png
SCv3.3.6882-wrong-file2.png (19.7 KiB) Viewed 537 times
This was the temp file for last plate solve...
User avatar
admin
Site Admin
Posts: 6140
Joined: Sat Feb 11, 2017 3:52 pm
Location: Vale of the White Horse, UK
Contact:

Re: v3.3.6882 - offers to delete wrong frame

Post by admin »

Ok, interesting - 2 bugs there I think - I will investigate.

thanks,

Robin
celkins
Posts: 52
Joined: Fri Apr 20, 2018 10:58 pm

Re: v3.3.6882 - offers to delete wrong frame

Post by celkins »

Quick update: 3.3.7030 still offers to delete the wrong files, and the capture directory isn't updated correctly - looks like the "start capture" code path doesn't set the "current capture target directory" variable, nor the "last frame captured" upon write-frame...
User avatar
admin
Site Admin
Posts: 6140
Joined: Sat Feb 11, 2017 3:52 pm
Location: Vale of the White Horse, UK
Contact:

Re: v3.3.6882 - offers to delete wrong frame

Post by admin »

Hi,

I think there's an issue here that the options to delete the last capture file and to open the capture folder only really apply properly to captures that are fully completed. That means they won't work for deleting the last frame while SharpCap is still capturing (or at least they certainly won't work correctly). What I'm going to try to do to for now is to disable those menu options whilst SharpCap is capturing to at least avoid the confusion that arises due to the current behaviour. I think that deleting the last frame while capturing is active is a good idea, but will require significantly more code changes.

Cheers, Robin
celkins
Posts: 52
Joined: Fri Apr 20, 2018 10:58 pm

Re: v3.3.6882 - offers to delete wrong frame

Post by celkins »

Thanks for the update, Robin.
As you probably guessed, my use case is during a capture run, the wind, for example, buffets the scope, guiding goes wild, and the next frame is heavily trailed: great to just be able to clobber this bad frame, rather than having to hunt it out later.
Quite understand if it was initially aimed at a slightly different case, and thus needs more code changes... which would probably put it further down the list, due to risk at this stage in the release cycle.

Thanks for all your work, and excellent software.

Carl
procyon12
Posts: 130
Joined: Tue Jan 14, 2020 11:32 am

Re: v3.3.6882 - offers to delete wrong frame

Post by procyon12 »

Hi,

So far I didn't know that the last recording could be deleted, a good feature.
Just tested with 3.3.7030 32bit under W7-64: the captured image file and the CameraSettings.txt are deleted but not so the file ...Histogram.csv.
Regarding ...Histogram.csv - can be added an option to switch off automatically saving it?

Cheers, Christian
User avatar
admin
Site Admin
Posts: 6140
Joined: Sat Feb 11, 2017 3:52 pm
Location: Vale of the White Horse, UK
Contact:

Re: v3.3.6882 - offers to delete wrong frame

Post by admin »

Hi Christian,

yes, I noticed the histogram.CSV problem myself when testing the other day and it's on my list of things to do. I will also put down control over its creation on the to-do list.

Cheers, Robin
procyon12
Posts: 130
Joined: Tue Jan 14, 2020 11:32 am

Re: v3.3.6882 - offers to delete wrong frame

Post by procyon12 »

Thanks, Robin
Post Reply